Skip to content

Conversation

@TobiGr
Copy link
Contributor

@TobiGr TobiGr commented Dec 25, 2025

Reverts #1420

Rhino 1.9.0 throws an error while trying to build and minify with minSDK < 26:

Stacktrace
Execution failed for task ':app:mergeExtDexDebug'.
> Could not resolve all files for configuration ':app:debugRuntimeClasspath'.
   > Failed to transform rhino-1.9.0.jar (org.mozilla:rhino:1.9.0) to match attributes {artifactType=android-dex, dexing-component-attributes=ComponentSpecificParameters(minSdkVersion=24, debuggable=true, enableCoreLibraryDesugaring=true, enableGlobalSynthetics=true, enableApiModeling=false, dependenciesClassesAreInstrumented=false, asmTransformComponent=null, useJacocoTransformInstrumentation=false, enableDesugaring=true, needsClasspath=false, useFullClasspath=false, componentIfUsingFullClasspath=null), org.gradle.category=library, org.gradle.dependency.bundling=external, org.gradle.jvm.version=11, org.gradle.libraryelements=jar, org.gradle.status=release, org.gradle.usage=java-runtime}.
      > Execution failed for DexingNoClasspathTransform: /home/tobias/.gradle/caches/modules-2/files-2.1/org.mozilla/rhino/1.9.0/fa35ed9a35d456bda30c817d7337a6e88ccc1e1e/rhino-1.9.0.jar.
         > Error while dexing.
           Increase the minSdkVersion to 26 or above.

@TobiGr TobiGr added the dependencies Pull requests that update a dependency file label Dec 25, 2025
@TobiGr TobiGr force-pushed the revert-1420-dependabot/gradle/rhino-1.9.0 branch from 66cbd20 to 2c60422 Compare December 25, 2025 10:47
@TobiGr TobiGr merged commit 4b27201 into dev Dec 27, 2025
2 of 4 checks passed
@TobiGr TobiGr deleted the revert-1420-dependabot/gradle/rhino-1.9.0 branch December 27, 2025 15:18
@absurdlylongusername
Copy link
Member

@TobiGr How come CI didn't catch this before merging? Or do we not run CI on dependabot PRs?

@TobiGr
Copy link
Contributor Author

TobiGr commented Dec 28, 2025

There are only unit tests for the extractor but no tests for integration in the app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants