[YouTube] Fallback to avatarThumbnailUrl for comment thumbnails - #1525
Merged
TobiGr merged 1 commit intoJul 29, 2026
Merged
Conversation
FineFindus
commented
Jul 27, 2026
Comment on lines
+175
to
+176
| 88, | ||
| 88, |
Contributor
Author
There was a problem hiding this comment.
I hardcoded the size, as all avatars appear to by 88x88, but I'm happy to change it to UNKOWN instead.
Contributor
There was a problem hiding this comment.
It would be good to have some kind of automated check / test that checks the hard-coded values from time to time. I think we do not need to implement it in this PR. Can be moved into a separate issue because it's not blocking.
FineFindus
marked this pull request as draft
July 27, 2026 20:23
AudricV
added
bug
FineFindus
force-pushed
the
fix/channel-comment-thumbnails
branch
from
July 28, 2026 17:46
a10b78f to
88ad04f
Compare
FineFindus
marked this pull request as ready for review
July 28, 2026 17:46
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue, where the comment payload does not contain the avatar object, and therefore the channel thumbnail is not extracted. This is currently in an A/B test, so it' doesn't happen every time.
Closes: libre-tube/LibreTube#8619.
Closes: TeamNewPipe/NewPipe#13731
I know this probably requires regenerating the mocks, but I spend >30 minutes fighting with gradle, so at this point it's a take-it-or-leave-it situation :)