Add serial port devices searching/updating #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: - serial readyread signal isn't quite working mid-ops, so we miss a lot of debug output - a lot of Qt threading complaints when stopping and re-docking
…while no device is currently synced
|
Why the f did Qt6 change the QtConcurrent run syntax again? Thank heck the full multithreading didn't go through, otherwise that'd be enough for me to bump req's to Qt6 just so I don't have to do needlessly repetitive preprocessor ifs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original "board must be connected" requirement has been removed, as is the old "alive timer" method of sending characters to check if the device is still connected - now ports are searched at the alive timer interval (on its own thread), and is compared - any differences will overwrite the list of COM devices in the main app window, including accounting for going to/from "no valid devices".
Alongside this, everything directly serial related have been moved to their own AppSerial class.
On a side note, profiles count is now determined exclusively by the size of the profiles tables collected during initial sync - so the App should be able to handle any amount of profiles should a custom firmware use larger profile tables.
Closes #16 (finally)