Update serial communications to work with FW 6.x+, decouple I2C peripheral for new addons #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…consistent error handling
… use pinboxes count more whenever possible (except for initial pinBoxes construction)
- Close port in GetSettings before trying to set and start a new device. - Fix duplicating current port when adding new devices, if it was still available - Append the device's name to the entry in the COM port selector
…disable unused 'Battery' item
Boards previewer shares much of the same code as the main window's board layout generation routine, just referencing only static layouts as defined in `OpenFIREshared.h`.
…isplay-related options - also actually send profile data out this time
…e Commit method. This SEEMS to avoid possible race-y issues/corruption with declaring independent buffer space for each submethod that seemed to cause strange output to be sent, which ultimately didn't match and sent an emergency terminator.
…ing trackable markers
… originally synced data, add to+opt DiffUpdate
|
I would gladly try to help, but there are too many changes all at once and I wouldn't know where to start, and I don't even know qt very well, in fact almost not at all even if they are quite intuitive... if you give me some specific tasks I'll try |
|
@alessandro-satanassi there is no involvement from you needed; it's just so you were aware that work was ongoing already. 🙂 |
|
Completely unrelated note-to-self, fullscreen cali window needs a tweak to its background. But that should ought to be handled outside of an already big PR. Everything else looks good from the testing I've done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily a sister PR to TeamOpenFIRE/OpenFIRE-Firmware#60, the app's communications syntax has been changed to reflect what will be used in FW 6.0-onwards.
I2C Peripheral decoupling is a thing now, which means the display is considered its own accessory and can be individually enabled/disabled. This should hopefully allow easy integration with future I2C devices.
Analog stick reading actually reflects proper analog positioning, rather than the old hacky 8-directional label workaround before.
The settings screen layout has been additionally reorganized to be more intuitive; even though the page overall takes up more space, the options should speak more for themselves.
A window for previewing supported Boards (and their default layouts) has been added under the Help app menu.
The one-time check for supported devices has been removed - the app will be able to startup without any connected devices, and will search for new devices at a set 5s interval; removing old devices as they are disconnected and adding new ones as they are added.
Valid camera checks are more thorough now (mainly due in part to new checks signaled from FW 6.0), and the app/FW will check at startup and with every syncing of settings if the assigned camera and/or peripherals line is either available or wired correctly.
Reboot to Bootloader now uses the magic 1200baud switch correctly, allowing devices to be rebooted regardless of working status or not - the App will even report if a device has failed to sync and ask the user if they wish to reboot this board appropriately.
Most references to fixed Pin Counts are removed (TODO: save for one), prepping work for devices or platforms with more than 30 assignable GPIO maximum. (This means ESP as well, though that platform may need a different method for the aforementioned Reboot to Bootloader change.