Corrects packet reading/waiting logic for >64B transactions from microcontroller, add custom temperatures support #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…64B max, fix reading out-of-bounds when no bytes available in reading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out, reading logic for longer transactions was fuuuucked and either didn't work, waited too early, or (more commonly) causes an out-of-bounds read exception when peeking into the port when there was no data in a routine that expects to exit via
serialTerminator. That was my bad, so this should fix that.Tested with the firmwares with a long-enough settings (temperature settings), the app reads it without any noticeable additional wait in the transaction.
Temperatures can now be customized. However, since the defaults were picked for very good reason and are going to reduce life of solenoid when raised, these are hidden behind the new Show Unsafe Settings toggle, appropriately under the new View appmenu category.