Improve Pin Highlighting to be more flexible to source file formatting #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of searching for a pair of strings with exact spacing and formatting, it should now just work with generic output, so long as the style line goes BELOW the id line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of feedback regarding the difficulty of implementing highlights originally, the method was made more robust so that it uses an iterator for each individual element of the needed strings to get to the
opacity:0line that needs to be modified, rather than depending on exact formatting that demanded required manual intervention.Depending on the app used to export these files, some manual tweaking might still be needed? But at least now it won't break if, for example, someone modifies from Windows with its insistence on Carriage Return+Newlines.
Incidentally, this is also what was needed to make the GH actions artifacts actually show highlights? Neat!
Also, Arduino Nano pic works now. Oops.