Feature/ogg opus wrapper #108
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a class that just wraps pre-encoded opus data in an ogg stream instead of encoding PCM data and wrapping it. I needed it for an opus stream from a camera. It seems to work with FFMPEG. It seems like this could be useful to others, so I thought I would submit a PR.
Please let me know if I've done something foolish. I did not handle the pre-skip stuff at all, which may be an issue, but I don't know many of the low-level opus settings the camera is using (frame size, pre-skip, etc.) and I've had a hard time finding out how to infer them from the opus packets (if that's even possible)