Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/408 mypage temperature bug #411

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Fix/408 mypage temperature bug #411

merged 2 commits into from
Jul 9, 2024

Conversation

choiseona
Copy link
Member

@choiseona choiseona commented Jul 9, 2024 •
edited
Loading

๐Ÿšจ Pull request ์ „์— ํ™•์ธํ•ด์•ผ ํ•  ์‚ฌํ•ญ( [x] ์ฒดํฌํ•ด์ฃผ์„ธ์š” )

  • ๋ฐ˜๋“œ์‹œ ํ™•์ธํ•  ๊ฒƒ!
    pull a topic/feature/bugfix branch ์—์„œ dev branch๋กœ PR์š”์ฒญํ•˜๋Š”์ง€ ํ™•์ธํ•˜์„ธ์š”.
    master/main์— ํ•˜์‹œ๋ฉด ์•ˆ๋ฉ๋‹ˆ๋‹ค.

  • ์ปค๋ฐ‹ ๋˜๋Š” ๋ชจ๋“  ์ปค๋ฐ‹์˜ ๋ฉ”์‹œ์ง€ ์Šคํƒ€์ผ์ด convention๊ณผ ์ผ์น˜ํ•˜๋Š”์ง€ ํ™•์ธํ•ด์ฃผ์„ธ์š”.

  • PR์ž‘์—…์— ๋Œ€ํ•œ ์˜ค๋ฅธ์ชฝ์˜ ๋ผ๋ฒจ์„ ๋ถ™์—ฌ์ฃผ์„ธ์š”.

๐Ÿ“Œ ๊ฐœ์š”

๋งˆ์ดํŽ˜์ด์ง€ ์˜จ๋„ ๋™์  ์Šคํƒ€์ผ๋ง ๋ฒ„๊ทธ ํ•ด๊ฒฐํ–ˆ์Šต๋‹ˆ๋‹ค.

#408

โœจ ์ž‘์—… ๋‚ด์šฉ

์˜จ๋„์— ๋งž๋Š” ์ƒ‰๊น”์„ ๋ฐ˜ํ™˜ํ•  ๋•Œ ์ƒ‰๊น” ์ฝ”๋“œ๋งŒ์ด ์•„๋‹ˆ๋ผ "bg-[#000000]" ์ž์ฒด๋กœ ๋ฐ˜ํ™˜ํ•˜๋„๋ก ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค.

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท(์„ ํƒ)

๐Ÿ”Š ๋ฆฌ๋ทฐ์–ด์—๊ฒŒ(์„ ํƒ)

๐Ÿ“š ์ถ”๊ฐ€ ์‚ฌํ•ญ(์„ ํƒ)

tailwind์—์„œ ๋™์  ์Šคํƒ€์ผ๋ง์„ ์ ์šฉํ•˜๋ ค๋ฉด ์™„์ „ํ•œ ํด๋ž˜์Šค ์ด๋ฆ„์„ ์‚ฌ์šฉํ•ด์•ผ ํ•œ๋‹ค.

@choiseona choiseona added the bug Something isn't working label Jul 9, 2024
@choiseona choiseona self-assigned this Jul 9, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 9, 2024

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
gitget โฌœ๏ธ Ignored (Inspect) Jul 9, 2024 8:15am

@choiseona choiseona merged commit 4ff7719 into dev Jul 9, 2024
3 checks passed
@choiseona choiseona deleted the fix/408-mypage-temperature-bug branch July 9, 2024 11:20
choiseona added a commit that referenced this pull request Jul 11, 2024
@choiseona
Fix/408 mypage temperature bug (#411)
2a8580e 
* Fix: ๋งˆ์ดํŽ˜์ด์ง€ ์˜จ๋„ ๋™์  ์Šคํƒ€์ผ๋ง ๋ฒ„๊ทธ ํ•ด๊ฒฐ

Related to: #408

* Fix: ๋งˆ์ดํŽ˜์ด์ง€ ์˜จ๋„ ๋™์  ์Šคํƒ€์ผ๋ง ๋ฒ„๊ทธ ํ•ด๊ฒฐ

Related to: #408
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@choiseona choiseona

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@choiseona