Skip to content

Expand information about infobox in webhook config #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tw-martijn
Copy link

I was doing a lot of testing w.r.t. displaying errors when things have not been fully configured on a customer’s account on our end. I noticed:

  1. it seems like the infoboxes no longer use icons (I think they did before?) and only apply styling. E.g. bg-warning and bg-danger classess.
  2. it is possible to use infoboxes as a replacement for the error type field by making sure required is set to true. Doing that will disable the “Add trigger” button. This way some messages can use warning styling but still block the end-user from creating the trigger in their job.

Expand on the options for infobox
@tw-martijn
Copy link
Author

I was inspired to test the required trick after seeing the example form-config-error from the example-webhook repository. That one uses the hidden type, but that seems unnecessary when the error can be rendered to the end-user with an infobox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant