Open
Conversation
Cherry-picked from PR microg#3377 by hasali19 This fixes a few issues preventing casting from working properly: - Fixed CastContextImpl.setReceiverApplicationId to actually register session providers - Fixed SessionImpl start ordering - Fixed CastDeviceControllerImpl connection handling - Added connect() and addListener() methods to ICastDeviceController - Added onConnected callback to ICastDeviceControllerListener - Fixed CastMediaControlIntent.categoryForCast to include ALLOW_IPV6 suffix
|
@TeapoyY great. |
|
Hey I see you already had a PR on the official MicroG. That got closed by being labeled as AI Slop? Can you confirm you are not AI please, fix any issues I've seen there and re-raise again there? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microg#580. Implements Google Cast support for GmsCore.
This PR cherry-picks and improves upon PR microg#3377 by hasali19, fixing several issues preventing Google Cast from working properly with microG:
Changes:
Testing:
This implementation has been tested with the YouTube app on a CCwGTV device (with hardcoded address since emulator can't do mDNS). The session can be started and media playback can be controlled. Disconnect process has some minor issues that are being addressed in follow-up work.
Bounty:
This PR addresses the Google Cast Implementation bounty (issue microg#580) on BountyHub.