Warn if frameworks exceed the maximum number of test mutations #9667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p8
force-pushed
the
toolset/10-test-only
branch
from
382a454 to
5f06d66
Compare
|
I think what I would prefer is that users would get a warning when working on their implementation locally - specifically, it should call out that the max has already been reached, and if they are still set on getting their framework into the tests they need to contact maintainers and remove deprecated or discarded ones to make room. This puts a lot of unfair effort on the part of a potential contributor to do more than just add their framework... I just don't have a better solution off hand. |
p8
force-pushed
the
toolset/10-test-only
branch
from
5f06d66 to
21a552d
Compare
|
@msmith-techempower I'm showing a warning now, similar to the warning if the "default" test variant is missing. |
> The number of test mutations will be limited to 10. TechEmpower#8420 This change shows a warning message for frameworks if the maximum is reached.
p8
force-pushed
the
toolset/10-test-only
branch
from
21a552d to
a87fac5
Compare
|
Made sure broken tests aren't taken into account. |
p8
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #8420 test mutations should be limited.
This change makes mutations fail for frameworks if the maximum is reached.This change shows a warning message for frameworks if the maximum is reached.