Skip to content

feat(localization): Add Korean translation#1000

Open
lancard wants to merge 10 commits intoTecharoHQ:mainfrom
lancard:main
Open

feat(localization): Add Korean translation#1000
lancard wants to merge 10 commits intoTecharoHQ:mainfrom
lancard:main

Conversation

@lancard
Copy link
Copy Markdown

@lancard lancard commented Aug 20, 2025

Checklist:

  • Added a description of the changes to the [Unreleased] section of docs/docs/CHANGELOG.md
  • Added test cases to the relevant parts of the codebase
  • Ran integration tests npm run test:integration (unsupported on Windows, please use WSL)

Signed-off-by: Jason Cameron <[email protected]>
Comment thread lib/localization/locales/ko.json Outdated
Comment thread lib/localization/locales/ko.json
Comment thread lib/localization/locales/ko.json Outdated
Comment thread lib/localization/locales/ko.json Outdated
Comment thread lib/localization/locales/ko.json
Comment thread lib/localization/locales/ko.json
Signed-off-by: Sung-ho Kim <[email protected]>
Signed-off-by: Sung-ho Kim <[email protected]>
Comment thread lib/localization/locales/ko.json Outdated
Comment thread lib/localization/locales/ko.json Outdated
Comment thread lib/localization/locales/ko.json
Signed-off-by: Sung-ho Kim <[email protected]>
Signed-off-by: Sung-ho Kim <[email protected]>
Signed-off-by: Sung-ho Kim <[email protected]>
@bunubbv
Copy link
Copy Markdown

bunubbv commented Aug 27, 2025

LGTM. Thank you for considering the feedback!

@Xe
Copy link
Copy Markdown
Contributor

Xe commented Aug 29, 2025

Is this safe to merge?

@lancard
Copy link
Copy Markdown
Author

lancard commented Aug 29, 2025

Is this safe to merge?

If you are asking me, the answer is yes. Although there was a difference in interpretation, we both reached an agreement. If there is any technical issue, please let me know. I will make the necessary corrections.

@dxdxdt
Copy link
Copy Markdown

dxdxdt commented Apr 6, 2026

It's missing missing_required_forwarded_headers, but that's only required when sysadmins are testing the config. If end users start seeing that message, it means that something is gone horribly wrong, so it should be fine.

Someone made #1549 without realising that op @lancard beat them to it. As a Korean speaker, I find this PR way better than #1549. In Asian languages, we have this thing called honorifics which determines the general tone even in written form. #1549 doesn't have any issue conveying the general information, but the general public would still prefer the formal tone rather than the "new tone" currently being pushed by the establishment. #1000 stands in the middle: not too informal, not too formal. In terms of gaining the trust of visitors, maintaining the formal tone is somewhat required for general purpose websites.

imo, #1549 is probably machine translated because if you look at: https://github.com/justcontributor/anubis/blob/e5b7a48de5d0fa9306f41396bbf9b6acbd0bb81b/lib/localization/locales/ko.json#L29

  "static_check_endpoint": "이는 역방향 프록시가 사용할 체크 엔드포인트예요.",

The word "reverse proxy" is literal translation. No native speaker uses that word.

@dxdxdt dxdxdt mentioned this pull request Apr 6, 2026
4 tasks
@lancard
Copy link
Copy Markdown
Author

lancard commented Apr 10, 2026

I've just read this comment. Is there anything I can help with?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants