feat(localization): Add Korean translation#1000
feat(localization): Add Korean translation#1000lancard wants to merge 10 commits intoTecharoHQ:mainfrom
Conversation
Signed-off-by: Jason Cameron <[email protected]>
Signed-off-by: Sung-ho Kim <[email protected]>
Signed-off-by: Sung-ho Kim <[email protected]>
Signed-off-by: Sung-ho Kim <[email protected]>
Signed-off-by: Sung-ho Kim <[email protected]>
Signed-off-by: Sung-ho Kim <[email protected]>
|
LGTM. Thank you for considering the feedback! |
|
Is this safe to merge? |
If you are asking me, the answer is yes. Although there was a difference in interpretation, we both reached an agreement. If there is any technical issue, please let me know. I will make the necessary corrections. |
Signed-off-by: Xe Iaso <[email protected]>
|
It's missing Someone made #1549 without realising that op @lancard beat them to it. As a Korean speaker, I find this PR way better than #1549. In Asian languages, we have this thing called honorifics which determines the general tone even in written form. #1549 doesn't have any issue conveying the general information, but the general public would still prefer the formal tone rather than the "new tone" currently being pushed by the establishment. #1000 stands in the middle: not too informal, not too formal. In terms of gaining the trust of visitors, maintaining the formal tone is somewhat required for general purpose websites. imo, #1549 is probably machine translated because if you look at: https://github.com/justcontributor/anubis/blob/e5b7a48de5d0fa9306f41396bbf9b6acbd0bb81b/lib/localization/locales/ko.json#L29 "static_check_endpoint": "이는 역방향 프록시가 사용할 체크 엔드포인트예요.",The word "reverse proxy" is literal translation. No native speaker uses that word. |
|
I've just read this comment. Is there anything I can help with? |
Checklist:
[Unreleased]section of docs/docs/CHANGELOG.mdnpm run test:integration(unsupported on Windows, please use WSL)