fix: nil deref when solve request lands on a different DIFFICULTY than the original req#1467
Merged
fix: nil deref when solve request lands on a different DIFFICULTY than the original req#1467
Conversation
Signed-off-by: Jason Cameron <jason.cameron@stanwith.me>
JasonLovesDoggo
force-pushed
the
json/fix-pow-deref
branch
from
52c6003 to
dd6b44d
Compare
Signed-off-by: Jason Cameron <git@jasoncameron.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PassChallenge re-evaluates the policy when the user submits their solution. If the weight lands on a different threshold (e.g. ALLOW instead of CHALLENGE), rule.Challenge is nil and the server panics. Fixes the root cause in check(), guards pre-hydration dereferences, and adds Valid() input validation to all challenge implementations.
Fixes: #1463
Checklist:
[Unreleased]section of docs/docs/CHANGELOG.mdnpm run test:integration(unsupported on Windows, please use WSL)