feat(crypto): remove @aws-crypto/sha256-js dependency#1563
Open
millette wants to merge 1 commit intoTecharoHQ:mainfrom
Open
feat(crypto): remove @aws-crypto/sha256-js dependency#1563millette wants to merge 1 commit intoTecharoHQ:mainfrom
millette wants to merge 1 commit intoTecharoHQ:mainfrom
Conversation
Signed-off-by: Robin Millette <robin@millette.info>
Contributor
|
This is intentionally implemented and used this way. Why are you removing the dependency? |
Author
|
Because it's been implemented in most browsers for a while now, over 10 years. So smaller client-side js. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
[Unreleased]section of docs/docs/CHANGELOG.mdnpm run test:integration(unsupported on Windows, please use WSL)