Open
Conversation
1. GeoIPCheckerFor stored country codes as-is (e.g., "CZ") 2. Check lowercased the lookup result before comparing (strings.ToLower(ipInfo.GetCountryCode())) So "CZ" in config never matched "cz" from the gRPC response. Signed-off-by: Jakub Lansky <jakub@lansky.biz>
Signed-off-by: Jakub Lansky <jakub@lansky.biz>
lenny87
force-pushed
the
thoth-geoip-compare-fix
branch
from
137b672 to
d75bf80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is case-sensitivity mismatch in geoipchecker.go
So "CZ", according to docs, in config never matched "cz" from the gRPC response.
Checklist:
[Unreleased]section of docs/docs/CHANGELOG.mdnpm run test:integration(unsupported on Windows, please use WSL)