Conversation
Before this did not respect the difficulty flag and instead used difficulty 4. This has been fixed. Signed-off-by: Xe Iaso <me@xeiaso.net>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes an issue where the default difficulty was hardcoded instead of using the specified policy value. It also introduces tests to ensure the default difficulty settings are correctly applied and updates the changelog accordingly.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/anubis_test.go | Added tests to validate that the default difficulty setting is applied correctly. |
| docs/docs/CHANGELOG.md | Updated the changelog with a note about fixing the default difficulty setting. |
| lib/anubis.go | Replaced the use of a hardcoded default difficulty with the dynamic policy value. |
JasonLovesDoggo
pushed a commit
to JasonLovesDoggo/anubis
that referenced
this pull request
Jun 17, 2025
Before this did not respect the difficulty flag and instead used difficulty 4. This has been fixed. Signed-off-by: Xe Iaso <me@xeiaso.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this did not respect the difficulty flag and instead used difficulty 4. This has been fixed.
Checklist:
[Unreleased]section of docs/docs/CHANGELOG.md