Add support for FlexRay symbols #2
Conversation
|
CI failed |
| @@ -36,6 +36,7 @@ struct flexray_frame | |||
| uint8_t cc; | |||
|
|
|||
| uint8_t data[254]; | |||
| uint8_t symbol_length; | |||
There was a problem hiding this comment.
In PCAP FlexRay symbol is defined as array of bytes, not just one value
|
The site explicitly states that a FR symbol frame has the measurement header of 1 byte and the symbol length of 1 byte, The SL[0..6] values represent a 7-bit unsigned integer (0-127). |
| @@ -163,6 +163,9 @@ namespace pcapng_exporter { | |||
| const uint8_t FR_HDR_SIZE = 7; | |||
| uint8_t fr[FR_HDR_SIZE + 254] = { 0 }; | |||
| fr[0] = (frame.channel << 6) | frame.type; | |||
| uint8_t frame_length; | |||
| if (frame.type == FR_TYPE_FRAME) | |||
There was a problem hiding this comment.
@aamereller, could you please fix the indentation inside the if / else blocks ?
|
@kayoub5 , could you please re run the CI ? do you have any other remarks ? |
|
ci failing |
I am not seing any pipeline being launched in #3. any explanation ? I am asking because nothing in the changes looks related to the CI failure. |
most likely because the branch came from a fork |
|
Regarding the CI: |
|
@aamereller , concerning the linux part, you can force the image For Windows CI, I will have a look and get back to you |
|
@aamereller , please try to replace this (https://github.com/Technica-Engineering/Technica.Traces.Pcapng.Exporter/blob/main/.github/workflows/cmake.yml#L32) with another altyernative since it seems that this issue is impacting others also in github. I have found different issues when searchin Please have a look on dotpcap/sharppcap#454 |
|
https://conan.io/center/recipes/libpcap?version=1.10.5 , you can have a look if needed to this alternative but it is not tested. (Thanks @kayoub5 for help) |
|
@aamereller , I think that the issue of CI on windows will persist because it is related tothe install of winpcap. Please refer to the previous suggestion |
|
@kayoub5 , CI is passing, do you still have any remark ? |
|
Hi @kayoub5, does this pull request look good to you? |
|
Do you already have matching PR for BLF or TECMP? |
| - name: Install (macos) | ||
| if: matrix.os == 'macos-latest' | ||
| run: brew install libpcap | ||
|
|
@kayoub5 , I think that those are topics that can be handled separetely in case of need |
The flexray export function does not support flexray frames as of now. The struct and exporter function have been adapted to also support FlexRay symbols.