19 global logging #22
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
May 26, 2022 02:34
…rnal-config` file
The interpolation system should be available to the users or at least test managers to configure the behavior of the tool.
I am already getting confused by all the multiple levels of configuration so it's better for general readability to name the original `config` file `model`, since it basically provides the data model
Describes intention better
…nually atm Whoever had the crazy idea to use YAML tags, should burn in hell. I wish there was something like `serde` for Python
…take This will always load the YAML post-initialization and will override some of the values you've set in the constructor. Hence this is wrong and you should only call `preload_configuration` on demand from `main`
The group needs to be fetched from `meta` and used in the formation of the log tree paths. This was not the case and we were ending up with the property name in the tree, e.g. `id` instead of the actual literal ID of the test cases.
Because `yaml` support in Python is frankly laughably bad and I only realized how bad after working with YAML in Rust
…lize as dict, luckily we can support both on `load`
Codecov Report
@@ Coverage Diff @@
## develop #22 +/- ##
===========================================
- Coverage 76.83% 75.32% -1.51%
===========================================
Files 14 15 +1
Lines 833 912 +79
===========================================
+ Hits 640 687 +47
- Misses 193 225 +32
Continue to review full report at Codecov.
|
|
TODO:
|
|
This MR will partly solve #17 as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List all Issues this Pull Request is meant to solve:
Run through our contribution checklist:
kalash/doc/contributing.md?nox -e json_schema, only if you did anything with the data model)?nox -e test)?flake8)?CHANGELOG.md?Describe shortly the changes you have introduced:
logginginterface, there is no need to wrap anything in my opinion. The global logger is a bit lower level since it will be predominantly used by the developers.internal-config.yaml. At the moment configuration preload is not happening at runtime because the scope of this change was just the logger but I needed the internal config for some smart handling of defaults that can be configured as per project. Users now have more control over how the per-test-case logs are grouped and how the file logs are named.Add additional comments (if any):
The checklist is incomplete because I'll run through the rest for a number of tickets at once.