-
Notifications
You must be signed in to change notification settings - Fork 42
Accessiblity Project - Water 2: Oscar, Ulrika, Malin #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
osckli990
wants to merge
53
commits into
Technigo:main
Choose a base branch
from
osckli990:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ulrika Einebrant <[email protected]>
…n for retaking quiz
…ged layout back to one question at a time without animation
NiklasAbrahamsson
approved these changes
Apr 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The inclusion of a skip button is a strong accessibility feature — well done.
- Error feedback and validation are implemented effectively, ensuring users are properly guided when mistakes occur.
- Great attention to color contrast in error messages — this is essential for visual accessibility.
- Nice implementation of “jump to focus” after an error, helping users quickly locate and fix issues.
- Focus is consistently set to the first radio button, which is excellent for both keyboard and screen reader users.
- The progress bar is informative and visually clear, giving users a good sense of where they are in the process.
- It’s also very helpful that users can navigate back and forth between questions.
- Good job following proper HTML order, paid attention to heading structure (e.g., H3 hierarchy), color usage, and overall semantic clarity — all of which contribute to a more accessible and well-structured experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link: https://js-project-accessibility.netlify.app/