Add CMake install#14
Open
steven-joruk wants to merge 1 commit intoTechnikEmpire:masterfrom
steven-joruk:add-install
Open
Add CMake install#14steven-joruk wants to merge 1 commit intoTechnikEmpire:masterfrom steven-joruk:add-install
steven-joruk wants to merge 1 commit intoTechnikEmpire:masterfrom
steven-joruk:add-install
Conversation
Owner
|
Hey @steven-joruk thanks for the pr. I'll have a detailed look over the changes later today, just wanted to say thanks for contributing! |
Owner
|
@steven-joruk I'll have to give this is a go on Windows and see what's up. I'll confess I'm not a cmake guy at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a CMake install target which also generates a pkg-config meta data file. The library name is kept as GQ, but it looks like there are other libraries out there with the same name - a brief search didn't show any
gq.pc's which they would clash with.libgq for gconf uses gq-gconf.pc, here. It might be good to add a prefix or suffix, but that's up to you.
It's not directly related, but I added a package to Arch's AUR for your project, available here. This patch is currently applied before installation.
Thanks.
Edit: I've moved the pkg-config file to within the UNIX specific block, but I'm unable to test the generic install section on anything other than Linux.