[IMP] support customization of the custom conf path. #512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LoisRForgeFlow
force-pushed
the
custom-conf-dir
branch
2 times, most recently
from
e52ff69 to
0c53693
Compare
ap-wtioit
reviewed
Sep 21, 2022
Contributor
ap-wtioit
left a comment
ap-wtioit
left a comment
There was a problem hiding this comment.
A test would be nice (test_dotd has a fragment that tests custom/conf.d maybe we could expand this)
# ``custom/conf.d`` was properly concatenated
("grep", "test-conf", "auto/odoo.conf"),
./custom is copied onbuild into /opt/odoo/custom and is chowned to root:odoo. In dev adding additional directories should be fine (if one exports UID, GID properly). but in other environments there could be permission issues with reading custom conf.d that do not belong to odoo uid inside the container.
Can we ignore such permission issues?
This allow you to potentially build different configuration files based on the environment you are using.
MarcelSForgeFlow
force-pushed
the
custom-conf-dir
branch
from
062da84 to
6da8fb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow you to potentially build different configuration files
based on the enviroment you are using.
@ForgeFlow