WEB-2373 Update OPEN_OCR_SCANNER spec - #243
Merged
Merged
Conversation
yamal-alm
commented
Jan 27, 2026
Comment on lines
-1845
to
+1846
| - `scannedText`: The scanned text matching the regex pattern, or `null` if the | ||
| user closed the scanner before any text was found | ||
| - `scannedText`: The scanned text matching the regex pattern. |
Contributor
Author
There was a problem hiding this comment.
we could have just added a new error code for the timeout case and keep this field nullable, however I preferred to avoid nulls as much as possible and give more semantic to each scenario. WDYT
yamal-alm
marked this pull request as ready for review
January 27, 2026 08:23
atabel
approved these changes
Jan 28, 2026
Comment on lines
-1845
to
+1846
| - `scannedText`: The scanned text matching the regex pattern, or `null` if the | ||
| user closed the scanner before any text was found | ||
| - `scannedText`: The scanned text matching the regex pattern. |
DavidMarinCalleja
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update OPEN_OCR_SCANNER so we can distinguish between: