Skip to content

B2PDE 2219 remove b2p methods - #245

Merged
atabel merged 8 commits into
masterfrom
B2PDE-2219-remove-b2p-methods
Feb 23, 2026
Merged

B2PDE 2219 remove b2p methods#245
atabel merged 8 commits into
masterfrom
B2PDE-2219-remove-b2p-methods

Conversation

@finuka

@finuka finuka commented Feb 10, 2026

Copy link
Copy Markdown
Contributor
  • B2PDE-2219 Remove getAppDomain method and b2p references in readme
  • B2PDE-2219 Remove refreshNavBar method
  • B2PDE-2219 Remove increaseAppRatingTrigger method
  • B2PDE-2219 Remove resetAppRatingTrigger method
  • B2PDE-2219 Remove appRatingRemindMeLater method

@finuka

finuka commented Feb 10, 2026

Copy link
Copy Markdown
Contributor Author

@atabel a bit of context here: As B2P project has been cancelled, we are deleting the methods that were created specifically for this project.

But I have a question here. I guess we should increase the major version as it is a breaking change. Should I do it now or you do it once you merge the branch?

@atabel atabel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we already removed all the usages of these methods in webapp?

Comment thread src/__tests__/app-rating-test.ts Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the warning here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups! done!

@atabel

atabel commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

But I have a question here. I guess we should increase the major version as it is a breaking change. Should I do it now or you do it once you merge the branch?

Yes, we'll need a major version. I'll change the version and release it once this is merged

@finuka

finuka commented Feb 20, 2026

Copy link
Copy Markdown
Contributor Author

Have we already removed all the usages of these methods in webapp?

These methods were never implemented in webapp, only in bp2 native repos (android and iOS). And those repositories are archived and no longer in use.

@finuka
finuka requested a review from atabel February 20, 2026 06:59
@atabel
atabel merged commit 7bb9335 into master Feb 23, 2026
2 checks passed
@atabel
atabel deleted the B2PDE-2219-remove-b2p-methods branch February 23, 2026 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants