VIVO-5866 set locator sdk mode correlation - #269
Merged
Conversation
Contributor
|
I think you should update the doc. |
|
a small introduction about the changes would have been appreciated :P |
|
watch out the title with a typo "VilVO" |
brtbrt
reviewed
Jun 10, 2026
| expect(msg.payload).toEqual({ | ||
| mode: 'observed', | ||
| correlation: {traceId: 'abc123'}, | ||
| }); |
There was a problem hiding this comment.
can you test corner test cases thru a test.each? I was thinking about
- empty object
correlation: {} - multiple fields
- undefined? / not passed
- ... any other idea?
Contributor
Author
|
Contributor
Author
I'd give you, but I don't have it. It's only a request from Vivo to add this parameter to improve traceability IMO. |
andyindahouse
changed the title
Marcosld
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#268