Skip to content

Fix: send button moves off screen when typing during a locked media recording #2267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuriipopow wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −1
Open

Fix: send button moves off screen when typing during a locked media recording #2267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ...es/TelegramUI/Components/Chat/ChatTextInputPanelNode/Sources/ChatTextInputPanelNode.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1810,7 +1810,13 @@ public class ChatTextInputPanelNode: ChatInputPanelNode, ASEditableTextNodeDeleg
}
}

let inputHasText = !(self.richTextInputNode?.inputContentIsEmpty ?? true)
// While a media recording is in progress the text field is faded out entirely (see
// audioRecordingItemsAlpha), but it can still be first responder and keep receiving keystrokes
// from an attached/software keyboard. Treating that invisible text as present would drive the
// whole right-hand side of the panel into its "send text" layout — which parks the recording
// controls (the mic/send-voice button) off screen at `width + 8.0`. The recording layout must
// stay independent of the field's content.
let inputHasText = !isRecording && !(self.richTextInputNode?.inputContentIsEmpty ?? true)

var hasMenuButton = false
var menuButtonExpanded = false
Expand Down