Proper handling of User on SIP URI #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the added tests show how user would be incorrectly inferred because the original code supposed that everything until @ was the user part. The other test shows a username with a period being considered a hostname (including the at symbol). Changed how auth part of the SIP URI is parsed by using the characters as expressed by the SIP-URI part of the grammar on the section 25.1 of the SIP protocol RFC (RFC 3261).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the added tests show how user would be incorrectly inferred because the original code supposed that everything until @ was the user part. The other test shows a username with a period being considered a hostname (including the at symbol). Changed how auth part of the SIP URI is parsed by using the characters as expressed by the SIP-URI part of the grammar on the section 25.1 of the SIP protocol RFC (RFC 3261).