fix: update use-prevent-scroll to fix iOS Safari flickering#232
fix: update use-prevent-scroll to fix iOS Safari flickering#232SimonEggert wants to merge 1 commit intoTemzasse:mainfrom
use-prevent-scroll to fix iOS Safari flickering#232Conversation
9bd3cdb to
11e8069
Compare
|
This seems to introduce some regressions unfortunately, so I'm closing the PR. FFR:
|
|
Hey @SimonEggert 👋🏻 Thanks for opening this PR. I was actually just doing the exact same thing and trying to update the I'll try to investigate if there is some middle ground solution that would fix the issue you mentioned while not creeping in any regressions. However I'm a bit skeptical about my ability to fix the issue as the iOS scroll prevention logic is pretty much black magic to me 😅 Let's hope AI can help here 🤞🏻 Please feel free to submit new PRs if you manage to find a fix 😊 |
|
Thanks for looking into this as well! FWIW, I forked and tested without With this combination, drag to close works and the flicker issue is gone. However, in the code there are comments about I will let you know if I find out anything else. Fingers crossed your AI is better than mine – I haven't had any success so far 😄 About the black magic: I found this to be a good writeup of the possible options: |
fixes #231
I've updated the
use-prevent-scroll.tsfile to the most up-to-date version of the upstream library. Unfortunately, it usesgetNonce.tswhich only got introduced a few days ago, so it is not available in@react-aria/utilspackage just yet. I copied it over for now and added a TODO.However, I tried a packed version of this change and could verify that it indeed resolves the flickering mentioned in the above issue. Could you please check if this would be an applicable solution or if anything prevents the update from being made?