fix: preserve input dtype instead of hardcoding float16 in attention layers#247
Open
Mr-Neutr0n wants to merge 1 commit into
Open
fix: preserve input dtype instead of hardcoding float16 in attention layers#247Mr-Neutr0n wants to merge 1 commit into
Mr-Neutr0n wants to merge 1 commit into
Conversation
|
|
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.half()calls with.to(x.dtype)inhydit/modules/attn_layers.pyto preserve the original input tensor's dtype.half()forces a downcast from bfloat16 to float16FlashSelfMHAModified.forward()(2 calls),FlashCrossMHAModified.forward()(3 calls), andCrossAttention.forward()IP-adapter path (1 call)Problem
Several places in the attention layer implementations hardcode
.half()after QK normalization and softmax operations. This forces the tensor dtype to float16 regardless of the actual training precision. When running in bfloat16 mode, this silently downcasts tensors from bfloat16 to float16, causing:Fix
Replace all
.half()calls with.to(x.dtype), which dynamically preserves whatever dtype the input tensorxuses. This is a backward-compatible change -- when running in float16 mode,x.dtypewill betorch.float16and behavior is identical to before.Test plan
.to(x.dtype)==.half()when input is float16)