fix(sglang): surface dropped rollout arguments - #392
Open
CjhHa1 wants to merge 1 commit into
Open
Conversation
Warn when SGLang ignores unknown ServerArgs keys, with an opt-in strict failure mode, so recipe typos and version skew no longer fail silently. Document and annotate the intended Qwen3 colocate, async, and LoRA rollout presets.
CjhHa1
requested review from
celve,
haonan3,
leviking98z-rgb and
zzhuoxin1508
as code owners
August 25, 2026 09:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ServerArgskeys, withUNIRL_SGLANG_STRICT_SERVER_ARGS=1available to fail closedRelated Issue
Fixes #261
Test Plan
SKIP=no-commit-to-branch uvx pre-commit run --all-files --show-diff-on-failure— passedserver_intent()precedence and reserved-port overrides — passed (20 focused assertions during development, followed by a compact reproducible smoke)Compatibility / Risk
Default behavior remains permissive: unknown SGLang keys are filtered as before but now emit a warning. Strict failure is opt-in through
UNIRL_SGLANG_STRICT_SERVER_ARGS=1. UniRL-only transport keys are excluded from warnings. No checkpoint, data-format, recipe-value, or resource-requirement changes.Reviewer Notes
AI-assisted implementation; the submitter reviewed the full diff. Duplicate-work check found no open PR addressing #261 or SGLang
ServerArgskey-drop validation.Checklist