fix(rollout): separate transfer and policy versions - #401
Open
quinnarnold wants to merge 1 commit into
Open
Conversation
quinnarnold
requested review from
Zcchill,
celve,
leviking98z-rgb and
zzhuoxin1508
as code owners
August 27, 2026 14:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep receiver-local weight-update call counts separate from the policy version stamped onto rollout output. Concrete rollout engines no longer overwrite published trainer provenance while receiving weight buckets or transfers.
Current trainer and rollout-manager publication ordering from #310 and #315 remains unchanged.
Related Issue
Fixes #324.
Test Plan
Compatibility / Risk
No configuration, checkpoint, data-format, or public API changes. Batch and agentic publication contracts are unchanged; only the conflicting internal receiver counter is separated.
Reviewer Notes
Later upstream work already implemented the trainer-to-worker version publication requested in #324, so this PR contains only the remaining four-engine counter separation. Duplicate searches found no overlapping open PR; #390 is unrelated. AI assistance was used; the complete diff and validation results were reviewed before publication.
Checklist