Skip to content

Bugfix/fix input content size change #4397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etkmao merged 2 commits into from
Sep 2, 2025
Merged

Bugfix/fix input content size change #4397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07688de
fix(ohos): fix input view contentSizeChange event
etkmao Sep 2, 2025
1d1067f
fix(android): fix input view contentSizeChange event
etkmao Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions framework/ohos/src/main/cpp/impl/renderer/native/src/components/text_input_view.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ bool TextInputView::SetPropImpl(const std::string &propKey, const HippyValue &pr
isListenKeyboardWillHide_ = HRValueUtils::GetBool(propValue, false);
CheckAndAddKeyboardListener();
return true;
} else if (propKey == "contentSizeChange") {
} else if (propKey == "contentsizechange") {
isListenContentSizeChange_ = HRValueUtils::GetBool(propValue, false);
return true;
} else if (propKey == "keypress") {
Expand Down Expand Up @@ -447,7 +447,7 @@ void TextInputView::SetText(const HippyValueArrayType &params){
auto& str = HRValueUtils::GetString(params[0]);
value_ = str;
GetTextNode().SetTextContent(value_.value());

// 注释 SetTextSelection 原因：
// 设置了也没效果，还偶现 OHOS::Ace::NG::UINode::MountToParent 里空指针 crash。
// int32_t len = (int32_t)str.length();
Expand Down Expand Up @@ -599,14 +599,14 @@ void TextInputView::OnKeyPress(const std::string &keyString) {
if(!isListenKeyPress_) {
return;
}

std::string resultKeyString = keyString;
if (keyString == " ") {
resultKeyString = "space";
} else if (keyString == "\n") {
resultKeyString = "enter";
}

HippyValueObjectType params;
params["key"] = resultKeyString;
const std::shared_ptr<HippyValue> obj = std::make_shared<HippyValue>(params);
Expand Down
2 changes: 1 addition & 1 deletion ...android/src/main/java/com/tencent/mtt/hippy/views/textinput/HippyTextInputController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ public void setOnKeyboardWillHide(HippyTextInput hippyTextInput, boolean enable)
hippyTextInput.setEventListener(enable, HippyTextInput.EVENT_KEYBOARD_HIDE);
}

@HippyControllerProps(name = "contentSizeChange", defaultType = HippyControllerProps.BOOLEAN)
@HippyControllerProps(name = "contentsizechange", defaultType = HippyControllerProps.BOOLEAN)
public void setOnContentSizeChange(HippyTextInput hippyTextInput, boolean contentSizeChange) {
hippyTextInput.setOnContentSizeChange(contentSizeChange);
}
Expand Down
Loading