fix(knowledge): use current parser rules for batch reparse - #2763
Open
Jonesxq wants to merge 1 commit into
Open
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 task
sakitam-fdd
added a commit
to sakitam-fdd/WeKnora
that referenced
this pull request
Aug 21, 2026
Port upstream Tencent#2763 onto the fork's current main. This clears upload-time parser engine rule snapshots only for nil-config batch reparses, so reparsing uses the knowledge base's current parser rules while preserving document-specific chunking, multimodal, and parser options.
sakitam-fdd
added a commit
to sakitam-fdd/WeKnora
that referenced
this pull request
Aug 21, 2026
Port Tencent#2763 and Tencent#2711 after current-main review and fork-side validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Batch reparse tasks without an explicit
process_configreload each document's stored process overrides. Upload-time parser-engine snapshots then take precedence over the knowledge base's current parser rules, so changing the parser engine does not affect failed documents selected for batch reparse.This change clears only the stored parser-engine rule snapshots before a nil-config batch reparse:
chunking_configparser rules are removed;process_configand single-document reparse behavior are unchanged;This is a focused implementation against the current
main. It follows the backend direction discussed in the closed, unmerged #1901 and accounts for the nested snapshot identified there; #2094 explored a broader frontend-driven alternative.Type of Change
Related Issue
Fixes #1892
Testing
All focused commands pass; golangci-lint reports
0 issues.go test ./internal/application/service -count=1was also run. On Windows it fails only while removing SQLite temporary files in these existing tests:TestDataSourceServiceDeleteSQLiteCleansUpAfterSoftDeleteTestDataSourceServiceDeleteKeepsCleanupStateWhenSoftDeleteFailsTestDeleteKnowledgeBaseCleansUpSQLiteDataSourcesThe same
weknora.dbfile-lock cleanup failures reproduce on an unchangedmainworktree.Checklist
git diff --check origin/main...HEADpassesmainScreenshots / Recordings
Not applicable; this is a backend batch-processing fix.