Repository navigation
feat(knowledge): move folders with drag and drop or actions menu - #4461
Closed
Annabelle0726 wants to merge 1 commit into
Closed
Annabelle0726 wants to merge 1 commit into
Annabelle0726 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add two ways to change a knowledge folder's parent: drag it onto another folder (or the knowledge-base root), or use Actions → Move to folder. Both reuse the existing folder move endpoint and preserve the folder name, descendants, selected path and recursive document counts.
useConnectorLabelmock in the existing assistant-refresh test fixture, which otherwise prevents the current upstream frontend suite from passing.Type of Change
Testing
npm test: 1,800 passed, 0 failed, 1 existing skip.npm run type-check: passed.NODE_OPTIONS=--max-old-space-size=4096 npm run build: passed; existing large-chunk warnings only.go test ./internal/application/repository: passed, including the regression that fails on unmodified upstream.go vet ./...andgo build ./cmd/server: passed on this branch../internal/application/repository: 0 issues, successful exit.Checks used Linux Go 1.26.9 and Node 24. Upstream GitHub Actions currently require maintainer approval (
action_required); remote CI has not run yet.Browser verification used Chromium and an isolated API fixture: drag/reparent, move to root, subtree preservation after refresh, menu/keyboard operation, Escape focus restoration, rejected cycles, failed requests retaining the original tree, and read-only permissions. The move menu was checked at 1920, 683 and 390 px. The existing workspace minimum-width layout still requires horizontal scrolling at 390 px; this PR does not redesign that layout.
Checklist
git diff --check upstream/main...HEADpassesScreenshots