Skip to content

fix(toolbar): apply heading levels across multiline selections - #1901

Merged
sunsonliu merged 3 commits into
Tencent:devfrom
SomSamantray:fix/issue-1900-heading-selection
Oct 14, 2026
Merged

sunsonliu merged 3 commits into
Tencent:devfrom
SomSamantray:fix/issue-1900-heading-selection

Conversation

@SomSamantray

Copy link
Copy Markdown
Contributor

Fixes #1900. Selecting ordinary text together with an existing heading and applying a heading level now applies that level consistently to both lines while preserving spacing after the existing marker.

Validation: vp run -F cherry-markdown test passed (2,237 tests), vp run typecheck passed, vp check completed with 0 errors, vp run build:core passed, and vp run -F cherry-markdown test:artifacts passed (7 tests). I also checked the behavior in the running editor; both lines became H1 and the browser reported no page errors.

Known limitations: None identified.

AI assistance: OpenAI Codex assisted with investigation, implementation, and verification.

@changeset-bot

changeset-bot Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: da8638c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
cherry-markdown Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tencent-adm

tencent-adm commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

CLA assistant check
All committers have signed the CLA.

@pkg-pr-new

pkg-pr-new Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

cherry-markdown

pnpm add https://pkg.pr.new/cherry-markdown@1901
npm i https://pkg.pr.new/cherry-markdown@1901
yarn add https://pkg.pr.new/cherry-markdown@1901.tgz

@cherry-markdown/miniprogram

pnpm add https://pkg.pr.new/@cherry-markdown/miniprogram@1901
npm i https://pkg.pr.new/@cherry-markdown/miniprogram@1901
yarn add https://pkg.pr.new/@cherry-markdown/miniprogram@1901.tgz

commit: da8638c

@cherry-markdown-bot

cherry-markdown-bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

💻 Client 构建产物

平台 架构 产物类型 下载
macOS Apple Silicon DMG 安装包 下载
macOS Apple Silicon App 应用 下载
macOS x64 App 应用 下载
macOS x64 DMG 安装包 下载
Windows x64 MSI 安装包 下载
Windows x64 EXE 安装程序 下载
Linux x64 AppImage 下载
Linux x64 Deb 包 下载

⏰ 产物保留 5 天

@cherry-markdown-bot

cherry-markdown-bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

🔌 VSCode Plugin 构建产物

下载 .vsix

⏰ 产物保留 5 天

@cherry-markdown-bot

Copy link
Copy Markdown
Collaborator

@sunsonliu sunsonliu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,感谢贡献~

@sunsonliu
sunsonliu merged commit 8c4f17b into Tencent:dev Oct 14, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Report] 连续选中普通文本和已有标题后,设置标题级别会重复添加标题标记

4 participants