Repository navigation
fix(engine): expose Engine instance type from CherryEngine - #1903
Merged
sunsonliu merged 1 commit intoOct 16, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 63bbf40 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
|
cherry-markdown
@cherry-markdown/miniprogram
commit: |
Collaborator
🔌 VSCode Plugin 构建产物
|
Collaborator
Collaborator
🌐 Playground 预览
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CherryEngineconstructor type sonew CherryEngine()is typed as theEngineinstance returned at runtime.Closes #1822.
Verification
yarn typecheck:core— passed.yarn test:core— 130 files, 2,419 tests passed.yarn lint— 0 errors; existing repository warnings remain.yarn build:core— passed.node node_modules/es-check/index.js es5 packages/cherry-markdown/dist/cherry-markdown.js— passed.yarn --cwd packages/cherry-markdown test:artifacts— 6 of 7 passed. On Windows, the ES5 test giveses-checka backslash absolute path, which its glob parser treats as missing. Running the equivalent ES5 check with a forward-slash path passes.