Skip to content

Fix potential integer overflow #2357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
djbn65 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix potential integer overflow #2357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions include/rapidjson/reader.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1484,7 +1484,7 @@ class GenericReader {
bool minus = Consume(s, '-');

// Parse int: zero / ( digit1-9 *DIGIT )
unsigned i = 0;
uint32_t i = 0;
uint64_t i64 = 0;
bool use64bit = false;
int significandDigit = 0;
Expand All @@ -1493,7 +1493,7 @@ class GenericReader {
s.TakePush();
}
else if (RAPIDJSON_LIKELY(s.Peek() >= '1' && s.Peek() <= '9')) {
i = static_cast<unsigned>(s.TakePush() - '0');
i = static_cast<uint32_t>(s.TakePush() - '0');

if (minus)
while (RAPIDJSON_LIKELY(s.Peek() >= '0' && s.Peek() <= '9')) {
Expand All @@ -1504,7 +1504,7 @@ class GenericReader {
break;
}
}
i = i * 10 + static_cast<unsigned>(s.TakePush() - '0');
i = i * 10 + static_cast<uint32_t>(s.TakePush() - '0');
significandDigit++;
}
else
Expand All @@ -1516,7 +1516,7 @@ class GenericReader {
break;
}
}
i = i * 10 + static_cast<unsigned>(s.TakePush() - '0');
i = i * 10 + static_cast<uint32_t>(s.TakePush() - '0');
significandDigit++;
}
}
Expand Down