fix(Tree): optimize tree traversal and node updates to prevent stack overflow#2305
Open
fix(Tree): optimize tree traversal and node updates to prevent stack overflow#2305
Conversation
16 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes tree traversal and node update operations to prevent stack overflow errors when handling large datasets (e.g., 200,000+ nodes). The main changes replace recursive implementations with iterative approaches using explicit stacks and loops.
Key Changes:
- Replaced recursive tree traversal (
walk()) with iterative stack-based implementation - Converted
Array.prototype.push.apply()and spread operators to explicit loops to avoid call stack limitations - Removed unnecessary array concatenation in favor of direct map operations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| js/tree-v1/tree-store.ts | Replaced spread operator with loop in refreshNodes() and optimized getRelatedNodes() to use direct map insertion instead of array concatenation |
| js/tree-v1/tree-node.ts | Converted recursive walk() method to iterative stack-based traversal and replaced spread operators with loops in appendNodes() and remove() |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
2bf33fa to
bc521b4
Compare
HaixingOoO
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
复现代码存档
📝 更新日志
fix(Tree): 优化大数据场景下产生的栈溢出
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单