- 
                Notifications
    
You must be signed in to change notification settings  - Fork 317
 
feature/zhangpaopao/picker aria #1705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            zhangpaopao0609
  wants to merge
  19
  commits into
  Tencent:develop
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
zhangpaopao0609:feature/zhangpaopao/picker-aria
  
      
      
   
  
    
  
  
  
 
  
      
    base: develop
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            feature/zhangpaopao/picker aria #1705
                    zhangpaopao0609
  wants to merge
  19
  commits into
  Tencent:develop
from
zhangpaopao0609:feature/zhangpaopao/picker-aria
  
      
      
   
              
            
      
        
          +261
        
        
          −13
        
        
          
        
      
    
  
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 
           @zhangpaopao0609 辛苦rebase一下dev分支,然后执行 npm run test:snap-update,处理一下测试快照问题~  | 
    
| 
           预览  | 
    
| 
           预览  | 
    
| 
           预览  | 
    
| 
           预览  | 
    
| 
           正在构建预览的二维码,请稍等...  | 
    
| 
           预览  | 
    
| 
           预览  | 
    
| 
           预览2  | 
    
          IOS
 Android
 103_1679402376.mp4127_1679402318.mp4通用问题“取消”“确认”按钮在视觉表现上位于最顶部的位置,目前是属于选择器中第三个获取焦点的元素,用户在选完每一列的选项之后只能将焦点往回滑才能点击“确认”按钮;建议可以考虑调整“取消”“确认”按钮的代码顺序,放在选择区域之后,朗读顺序可以依次为:  | 
    
          IOS
 Android
 通用问题这个确实是合理的,不过要修改的话恐怕得要重新写结构了(布局得改了)  | 
    
| 
           @LeeJim 帮忙关注下评论提到的“通用问题”  | 
    
| 
           预览  | 
    
| 
           预览2  | 
    
| 
           预览  | 
    
| 
           @zhangpaopao0609 大佬,抽空帮忙处理一下冲突~ +2  | 
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    








🤔 这个 PR 的性质是?
🔗 相关 Issue
fix #1066
fix #1051
💡 需求背景和解决方案
ios 录屏
📝 更新日志
☑️ 请求合并前的自查清单