feat: 添加constant协议转换 #184 #216
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Reviewed, transaction id: 41679
# Reviewed, transaction id: 41848
# Reviewed, transaction id: 41992
normal-wls
requested changes
Jul 1, 2025
bkflow/pipeline_converter/converters/json_to_data_model/pipeline.py
Outdated
Show resolved
Hide resolved
| show_type: str = "show" | ||
| validation: str = "" | ||
| custom_type: str | ||
| source_info: List[SourceInfo] |
Member
There was a problem hiding this comment.
这两个字段，source_info， source_tag印象中后端好像是不需要的，可以确认下
Collaborator
Author
There was a problem hiding this comment.
针对不同的变量，这两个字段有不同的消费，应该保留
# Reviewed, transaction id: 48602
# Reviewed, transaction id: 48614
# Reviewed, transaction id: 48679
normal-wls
requested changes
Jul 3, 2025
bkflow/pipeline_converter/converters/data_model_to_web_pipeline/constant.py
Outdated
Show resolved
Hide resolved
| for info in data.source_info: | ||
| info_field = info.value | ||
|
|
||
| if not (constant_key == info_field == tag_field): |
Collaborator
Author
There was a problem hiding this comment.
有关节点输出变量使用的应该都是字段名，并且是不允许修改的，这里应该是需要保持统一的
# Reviewed, transaction id: 48748
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed, transaction id: 41679