feat: 图表分析路由选取优先级调整 --story=137168746 - #11990
Conversation
JunLong-Lin
added
feat
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4cf0962a3f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if is_native_doris and (not index_set_obj.is_group or not is_legacy_doris): | ||
| self.table_id = f"bklog_index_set_{index_info['index_set_id']}" |
There was a problem hiding this comment.
For a non-group index that is now native Doris but still retains the internal Doris tag together with support_doris and doris_table_id, this condition selects the default route. However, BaseIndexSetHandler.get_index_set_table_info_list() treats that tag as a manual Doris connection and registers the default route exclusively against the legacy doris_table_id (bklog/apps/log_search/handlers/index_set.py:1938-1955), rather than the native LogIndexSetData storage. Consequently, this migrated configuration continues querying the legacy table—and may return stale or incorrect results—despite the intended native-storage precedence; the route-generation logic or this selection must account for the retained tag.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #11990 +/- ##
==========================================
+ Coverage 54.28% 61.28% +7.00%
==========================================
Files 807 926 +119
Lines 45868 67352 +21484
==========================================
+ Hits 24901 41280 +16379
- Misses 20967 26072 +5105 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 participants
已经接入 Doris 存储集群，并且同时存在历史遗留配置（support_doris + doris_table_id）的情况下：
索引组保持不变：优先走 analysis 路由
普通索引集：优先走 默认（bklog_indxe_set_xxx） 路由