Skip to content

feat: 镜像构建改为使用uv进行依赖安装 --story=123847581 #6163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

unique0lai
Copy link
Collaborator

No description provided.

@unique0lai unique0lai added feat A new feature. Correlates with MINOR in SemVer project/monitor project monitor labels May 6, 2025
@unique0lai unique0lai self-assigned this May 6, 2025
@unique0lai unique0lai requested a review from Copilot May 7, 2025 03:21
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project’s dependency management by switching to uv for dependency installation and grouping, while aligning dependency versions across configuration files.

  • Removed the redundant dependency from requirements_aidev.txt.
  • Updated pyproject.toml to use the [tool.uv] configuration and defined the aidev dependency group.
  • Enhanced the README with detailed instructions on creating virtual environments and managing dependencies with uv.

Reviewed Changes

Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.

File Description
bkmonitor/requirements_aidev.txt Removed a redundant dependency to defer management to the uv-enabled configuration in pyproject.toml.
bkmonitor/pyproject.toml Updated dependency versions and reorganized dependency groups into a uv-compatible format.
bkmonitor/README.md Added comprehensive documentation for using uv to manage dependencies.
Files not reviewed (3)
  • bkmonitor/.dockerignore: Language not supported
  • bkmonitor/Dockerfile: Language not supported
  • bkmonitor/requirements.txt: Language not supported
Comments suppressed due to low confidence (2)

bkmonitor/requirements_aidev.txt:7

  • [nitpick] Ensure that removing 'typing_extensions' from this file does not cause discrepancies in dependency management, and that it is fully handled by the pyproject.toml configuration.
-typing_extensions==4.12.2

bkmonitor/pyproject.toml:103

  • [nitpick] Consider moving the 'dev' dependencies into the [dependency-groups] section for consistency with the 'aidev' group, if uv supports grouping them.
dev = [

@unique0lai unique0lai requested a review from Copilot May 7, 2025 11:39
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR transitions dependency management to use uv for dependency installation and updates dependency configuration accordingly.

  • Removed the standalone typing_extensions dependency from the requirements file
  • Updated pyproject.toml to bump the typing-extensions version and introduce new uv configuration with dependency groups
  • Added documentation in README.md to guide developers on using uv

Reviewed Changes

Copilot reviewed 5 out of 8 changed files in this pull request and generated 1 comment.

File Description
bkmonitor/requirements_aidev.txt Removed the typing_extensions dependency to streamline deps
bkmonitor/pyproject.toml Updated dependency version and added new uv sections for grouping
bkmonitor/README.md Added documentation on using uv for dependency installation
Files not reviewed (3)
  • bkmonitor/.dockerignore: Language not supported
  • bkmonitor/Dockerfile: Language not supported
  • bkmonitor/requirements.txt: Language not supported
Comments suppressed due to low confidence (1)

bkmonitor/requirements_aidev.txt:7

  • The dependency is removed here using an underscore format, while in pyproject.toml it's referenced with a dash. Consider aligning the naming across files to prevent potential installation discrepancies.
-typing_extensions==4.12.2

@unique0lai unique0lai merged commit e7645b3 into TencentBlueKing:master May 7, 2025
3 checks passed
@unique0lai unique0lai deleted the feat/uv-dockerfile/#1010158081123847581 branch May 7, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat A new feature. Correlates with MINOR in SemVer project/monitor project monitor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant