fix(mcp): fix RawResponseEnabled hot reload not working - #2653
Merged
wklken merged 1 commit intoApr 21, 2026
Merged
Conversation
Why this change was needed: When changing RawResponseEnabled configuration for an MCP server, the setting was not taking effect without restarting the service. This was because genToolHandler captured the rawResponse bool value at handler registration time, so subsequent changes via SetRawResponseEnabled had no effect on already-registered tool handlers. What changed: - Changed genToolHandler signature from rawResponse bool to rawResponseGetter func() bool to accept a getter function - Updated tool handler to call rawResponseGetter() dynamically instead of using captured boolean value - Changed call sites to pass mcpServer.RawResponseEnabled method value instead of config.RawResponseEnabled boolean - Added unit tests for RawResponseEnabled getter behavior and concurrent access safety Problem solved: RawResponseEnabled configuration changes now take effect immediately without requiring service restart. Tool handlers dynamically read the latest value from MCPServer on each execution. Co-authored-by: claude <noreply@anthropic.com>
wklken
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change was needed:
When changing RawResponseEnabled configuration for an MCP server, the setting was not taking effect without restarting the service. This was because genToolHandler captured the rawResponse bool value at handler registration time, so subsequent changes via SetRawResponseEnabled had no effect on already-registered tool handlers.
What changed:
Problem solved:
RawResponseEnabled configuration changes now take effect immediately without requiring service restart. Tool handlers dynamically read the latest value from MCPServer on each execution.
Description
Fixes # (issue)
Checklist