fix(api): align v2 contracts and pagination - #3168
Merged
Merged
Conversation
Correct response status codes, request serializers, and collection shapes in Swagger metadata, registered gateway resources, and API documentation. Add contract tests covering the affected sync and MCP permission endpoints so future schema drift is detected without changing runtime behavior.
Why this change was needed: Several V2 list endpoints exposed inconsistent response envelopes or advertised pagination parameters without applying them. What changed: - Standardize V2 list responses on count/results - Apply limit/offset pagination after MCP record deduplication and to released resources - Synchronize runtime schemas, gateway definitions, documentation, and regression tests Problem solved: V2 list clients now receive a consistent pagination contract and pagination parameters affect the returned page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
countandresultslimit/offsetpagination to resource versions, MCP permission records, and released resourcesVerification
uv run make lint-checkuv run make test(3856 passed)10 passed)