fix queue not clearing after persisting buildings#45
Open
iain3000 wants to merge 1 commit intoTendsty:mainfrom
Open
fix queue not clearing after persisting buildings#45iain3000 wants to merge 1 commit intoTendsty:mainfrom
iain3000 wants to merge 1 commit intoTendsty:mainfrom
Conversation
* compare new upgrade.bought with old upgrade.level when cleaning up queue after applying persistence * add test case that (hopefully!) expresses the issue correctly; it fails without the change to `src/store/upgrade.js`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/store/upgrade.js** I'm happy to make changes to the test as it feels a bit ugly right now