fix(pilotctl): configurable appstore call timeout (default 120s, was hardcoded 8s)#244
Merged
Conversation
appstore call hardcoded an 8s socket read deadline, which cut off any legitimately slow method (multi-step research, cold LLM synthesis) long before it could return — surfacing as a spurious 'i/o timeout' even though the app and backend were healthy. Default to 120s and allow per-call --timeout / $PILOT_APPSTORE_CALL_TIMEOUT. The 8s was a reply deadline, not a dial timeout; dialing the local socket stays fast.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pilotctl appstore callset an 8s read deadline on the app socket, capping every method. Slow-but-healthy methods (e.g. cosift.research, ~11s; cold LLM answers) hit a spuriousi/o timeoutat 8s even though the app and backend completed fine.Fix: default the reply deadline to 120s; override with
--timeout <dur>or$PILOT_APPSTORE_CALL_TIMEOUT. Dial timeout stays short (local socket). Verified: cosift.research now returns in ~12s; fast methods unchanged;--timeoutparses.