Add columnDescription tool with linting and test cases#301
Merged
Conversation
dtehan-td
force-pushed
the
columnDescription
branch
from
da8db54 to
527539c
Compare
list[str] and list[int] annotations were used where str and int were intended, causing mypy errors across handle_base_columnMetadata and its helper functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
columnDescriptiontool tobase_tools.pywith linting fixescolumnDescriptionincore_test_cases.jsonandtest_cases.jsonbase_tools.pyTest plan
uv run ruff format --check src/— should pass with no files to reformatuv run ruff check src/— should pass with no errorsuv run python tests/run_mcp_tests.py "uv run teradata-mcp-server"columnDescriptiontest cases pass in the test report