Fix/skill top param pattern#330
Merged
Merged
Conversation
… skill
Teradata's parser rejects TOP followed by a bind-parameter placeholder (error 3707).
The example_tool.yml and the "Mixing styles" section of parameter-substitution.md
both used TOP :n, which is what caused the generated dba_running_sessions tool to
fail on first use. Replaced with a derived-table + ROW_NUMBER() + WHERE rn <= :n
pattern, which is safe for prepared statements. Added an explicit warning callout
in the reference doc covering TOP :n, TOP {n} (fragile), and SAMPLE :n.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dtehan-td
pushed a commit
to dtehan-td/teradata-mcp-server
that referenced
this pull request
Jun 8, 2026
* fix(skill): replace TOP :n with ROW_NUMBER() pattern in customisation skill
Teradata's parser rejects TOP followed by a bind-parameter placeholder (error 3707).
The example_tool.yml and the "Mixing styles" section of parameter-substitution.md
both used TOP :n, which is what caused the generated dba_running_sessions tool to
fail on first use. Replaced with a derived-table + ROW_NUMBER() + WHERE rn <= :n
pattern, which is safe for prepared statements. Added an explicit warning callout
in the reference doc covering TOP :n, TOP {n} (fragile), and SAMPLE :n.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* corrected SQL examples
---------
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
better examples in customisation skill for parameter handling