fix: upgrade Calcit messaging runtime - #33
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new GenAI chunk decoder still performs unconditional nested property/index reads that can throw on partial chunk shapes, and the legacy :done? default in normalization can mis-render the UI as “Streaming...” on load.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Upgrades the Calcit messaging/runtime and Respo dependency chain, while tightening the chat state and streaming pipeline by replacing nullable fields with concrete strings and centralizing GenAI stream chunk decoding behind a typed adapter.
Changes:
- Bump
@calcit/procsto0.13.72and update Calcit/Respo Calcits indeps.cirru. - Refactor streaming handling: introduce
StreamChunk+decode-genai-chunk, and enforce string-only streaming text viastream-text. - Normalize legacy persisted
ChatStateinto the new non-nullable schema (answer/thinkingas strings;modelas tag) and update UI call sites accordingly.
File summaries
| File | Description |
|---|---|
| yarn.lock | Locks the upgraded @calcit/procs version. |
| package.json | Updates the direct @calcit/procs dependency to match the runtime upgrade. |
| deps.cirru | Updates Calcit + Respo dependency versions used by the Calcit build. |
| calcit.cirru | Implements new typed streaming decode + chat-state normalization and updates schema/call sites to remove nullable text fields. |
Review details
- Files reviewed: 3/4 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prompt()API-key collection with an alerts prompt, validate blank keys, and map each provider model to its storage keyValidation
caps --strictyarn install --immutablecalcit edit formatcalcit --check-onlycalcit test(4 passed)calcit analyze quality --baseline config/calcit-quality.jsoncalcit jsyarn vite build --base=./undefined; Reply opens the API-key prompt when the provider key is absent; blank Save shows validation; no new native-prompt error is appended