Skip to content

Conversation

@staffordsmith83
Copy link

Current list of user feedback issues is not descriptive.
This PR should add the user provided issue description in the title of the github issue, or if not provided, add the username.

Im unsure how to test this short of deploying it.

Copy link
Contributor

@tephenavies tephenavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having the Referrer in the title is an important part of this improvement, and I'm not sure if using name is very useful (in the very rare case that comment is not present). I think just fallback to a placeholder.

@staffordsmith83
Copy link
Author

Hi @steve9164 Ana said she just wants the first part of the description in the ticket title - thats how she knows what the tickets are about when trolling through them. Adding the referrer in too means less description can fit in the title. And if people want referrer, then can open the ticket. Thoughts? I know its important, just that she is the one that asked for the feature in the first place so should have a good grasp on whats most useful for her as end user. Do you need to troll through these too sometimes?

@tephenavies
Copy link
Contributor

I'm happy to go with Ana's suggestion.

You can test it by creating a github PAT, running terriajs-server using this PAT and a GitHub repo in the feedback configuration and either faking a POST to /feedback or substituting your branch of terriajs-server into TerriaMap (using packages) and using the feedback button.

@staffordsmith83
Copy link
Author

Great, thanks @steve9164

@zoran995
Copy link
Contributor

Just an idea for the referer what about using it as a label, then it will also be visible at first but won't pollute the title and can be easily filtered on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants