Support creating Gists on Enterprise GitHub accounts#96
Open
etes wants to merge 1 commit intoTerriaJS:masterfrom
etes:master
Open
Support creating Gists on Enterprise GitHub accounts#96etes wants to merge 1 commit intoTerriaJS:masterfrom etes:master
etes wants to merge 1 commit intoTerriaJS:masterfrom
etes:master
Conversation
kring
reviewed
Feb 21, 2019
| var gistFile = {}; | ||
| gistFile[serviceOptions.gistFilename || 'usercatalog.json'] = { content: body }; | ||
|
|
||
| gistAPI = serviceOptions.gistAPI || githubGistAPI; |
Contributor
There was a problem hiding this comment.
I believe gistAPI is undeclared. Add a var in front.
Contributor
|
Thank for the PR @etes! It looks good other than that one comment. Could you please also create a pull request in TerriaJS adding yourself to https://github.com/TerriaJS/terriajs/blob/master/CONTRIBUTORS.md and sign the Contributors License Agreement (CLA)? |
Contributor
|
Hey @etes thanks again for this pull request! Any chance we can get you to sign the CLA so that we can merge it? The purpose of the CLA is just to ensure that we (and other users of terriajs-server) are allowed to use your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Enterprise supports self-hosted GitHub server. It should be possible to provide a custom Gist API URL as opposed to GitHub's default API,